Skip to content

Use logger in rpc client SendTransaction#401

Merged
silaslenihan merged 1 commit intodevelopfrom
use-real-logger-rpc-client
Mar 26, 2026
Merged

Use logger in rpc client SendTransaction#401
silaslenihan merged 1 commit intodevelopfrom
use-real-logger-rpc-client

Conversation

@silaslenihan
Copy link
Copy Markdown
Contributor

No description provided.

@silaslenihan silaslenihan requested a review from a team as a code owner March 26, 2026 16:32
@github-actions
Copy link
Copy Markdown
Contributor

👋 silaslenihan, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (4)

pkg/txmgr (4)
  • BroadcasterI — 🗑️ Removed

  • ConfirmerI — 🗑️ Removed

  • NewEvmTxm — Type changed:

func(
  *math/big.Int, 
  github.com/smartcontractkit/chainlink-framework/chains/txmgr/types.TransactionManagerChainConfig, 
  github.com/smartcontractkit/chainlink-framework/chains/txmgr/types.TransactionManagerTransactionsConfig, 
  KeyStore, 
  github.com/smartcontractkit/chainlink-common/pkg/logger.Logger, 
  TransmitCheckerFactory, 
  FwdMgr, 
  TxAttemptBuilder, 
  TxStore, 
  - BroadcasterI, 
  - ConfirmerI, 
  + *Broadcaster, 
  + *Confirmer, 
  *Resender, 
  - TrackerI, 
  + *Tracker, 
  Finalizer, 
  TxManager, 
  bool
)
*Txm
  • TrackerI — 🗑️ Removed

📄 View full apidiff report

ilija42
ilija42 previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

@silaslenihan
Copy link
Copy Markdown
Contributor Author

why

@ilija42 from this ticket

@silaslenihan silaslenihan force-pushed the use-real-logger-rpc-client branch from 0db360b to 1399499 Compare March 26, 2026 18:04
@silaslenihan silaslenihan enabled auto-merge (squash) March 26, 2026 18:07
@silaslenihan silaslenihan merged commit f2272e4 into develop Mar 26, 2026
35 checks passed
@silaslenihan silaslenihan deleted the use-real-logger-rpc-client branch March 26, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants